[SPARK-19509][SQL]Fix a NPE problem in grouping sets when using an empty column #16874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanzhai
changed the title
|
Can one of the admins verify this patch? |
asfgit
pushed a commit
that referenced
this pull request
Feb 9, 2017
…umns ## What changes were proposed in this pull request? The analyzer currently does not check if a column used in grouping sets is actually nullable itself. This can cause the nullability of the column to be incorrect, which can cause null pointer exceptions down the line. This PR fixes that by also consider the nullability of the column. This is only a problem for Spark 2.1 and below. The latest master uses a different approach. Closes #16874 ## How was this patch tested? Added a regression test to `SQLQueryTestSuite.grouping_set`. Author: Herman van Hovell <[email protected]> Closes #16873 from hvanhovell/SPARK-19509.
asfgit
pushed a commit
that referenced
this pull request
Feb 9, 2017
…umns ## What changes were proposed in this pull request? The analyzer currently does not check if a column used in grouping sets is actually nullable itself. This can cause the nullability of the column to be incorrect, which can cause null pointer exceptions down the line. This PR fixes that by also consider the nullability of the column. This is only a problem for Spark 2.1 and below. The latest master uses a different approach. Closes #16874 ## How was this patch tested? Added a regression test to `SQLQueryTestSuite.grouping_set`. Author: Herman van Hovell <[email protected]> Closes #16873 from hvanhovell/SPARK-19509. (cherry picked from commit a3d5300) Signed-off-by: Herman van Hovell <[email protected]>
|
@stanzhai I have merged my PR, and assigned the PR to your name. Could you close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
If a column of a table is all null values, the follow SQL will throw an NPE:
select count(1) from test group by e grouping sets(e).The reason is that when transformUp a
GroupingSetsinResolveGroupingAnalyticsit uses anullBitmaskto set an attribute with null ability, the nullable attribute may be modified.This pr just set all attribute's null ability to
truein group by expressions to fix the problem.The pr #15484 in master branch has fixed this problem.
We also need to fix this problem in branch-2.1.
How was this patch tested?
Test with Hive in my environment.