Skip to content

[SPARK-5984]Add notes and fix puzzling notes #17073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-5984]Add notes and fix puzzling notes #17073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/java/org/apache/spark/util/collection/TimSort.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,12 @@ private void pushRun(int runBase, int runLen) {
}

/**
* mergeCollapse should fully restore the invariant (see SPARK-5984).
* Examines the stack of runs waiting to be merged and merges adjacent runs
* until the stack invariants are reestablished:
*
* 1. runLen[i - 3] > runLen[i - 2] + runLen[i - 1]
* 2. runLen[i - 2] > runLen[i - 1]
* 2. runLen[i - 4] > runLen[i - 3] + runLen[i - 2]
*
* This method is called each time a new run is pushed onto the stack,
* so the invariants are guaranteed to hold for i < stackSize upon
Expand Down