-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-19805][TEST] Log the row type when query result dose not match #17145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #73806 has finished for PR 17145 at commit
|
|
Test build #73817 has finished for PR 17145 at commit
|
|
unrelated failure: |
|
Test build #73825 has started for PR 17145 at commit |
|
test crash. retest this please. |
|
Test build #73830 has finished for PR 17145 at commit
|
|
cc @srowen |
|
Test build #73832 has finished for PR 17145 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using schema.catalogString or schema.treeString here? Rolling your own seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, Iet me have a test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hvanhovell After use schema.catalogString
!== Correct Answer - 1 == == Spark Answer - 1 ==
!struct<_1:string,_2:string> struct<_1:int,_2:string>
![1,a] [1,a]
f5a35f6 to
2cff2b2
Compare
|
Test build #73919 has finished for PR 17145 at commit
|
|
cc @hvanhovell and @srowen |
|
LGTM - merging to master thanks. |
What changes were proposed in this pull request?
improve the log message when query result does not match.
before pr:
after pr:
== Results ==!== Correct Answer - 3 == == Spark Answer - 3 ==
!RowType[string] RowType[integer]
[1] [1]
[2] [2]
[3] [3]
How was this patch tested?
Jenkins