[SPARK-19737][SQL] New analysis rule for reporting unregistered functions without relying on relation resolution #17168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan @rxin |
|
Test build #73923 has finished for PR 17168 at commit
|
|
shall we refactor the way we resolve functions? we should get the function builder by name, then resolve all the children and build the function expression. |
liancheng
force-pushed
the
spark-19737-lookup-functions
branch
from
c9da94c to
393b689
Compare
|
@cloud-fan I'm afraid that's even more complicated an approach since you'll need to make function builders, which are now simply regular Scala functions, into unresolved expressions. |
liancheng
force-pushed
the
spark-19737-lookup-functions
branch
from
393b689 to
8a8a552
Compare
|
LGTM |
|
Test build #73980 has finished for PR 17168 at commit
|
|
Test build #73982 has finished for PR 17168 at commit
|
|
Thanks for the review! Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a new
Onceanalysis rule batch consists of a single analysis ruleLookupFunctionsthat performs simple existence check overUnresolvedFunctionswithout actually resolving them.The benefit of this rule is that it doesn't require function arguments to be resolved first and therefore doesn't rely on relation resolution, which may incur potentially expensive partition/schema discovery cost.
Please refer to SPARK-19737 for more details about the motivation.
How was this patch tested?
New test case added in
AnalysisErrorSuite.