[SPARK-19864][SQL][TEST]provide a makeQualifiedPath functions to optimize some code #17204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #74176 has finished for PR 17204 at commit
|
|
Test build #74188 has started for PR 17204 at commit |
|
Test build #74189 has started for PR 17204 at commit |
cloud-fan
reviewed
Mar 8, 2017
| * does not contain a scheme, this path will not be changed after the default | ||
| * FileSystem is changed. | ||
| */ | ||
| def makeQualifiedPath(path: URI, hadoopConf: Configuration): URI = { |
There was a problem hiding this comment.
how about taking path as a string?
|
Test build #74191 has finished for PR 17204 at commit
|
windpiger
force-pushed
the
addQualifiledPathUtil
branch
from
7c26d3e to
016cb12
Compare
|
Test build #74192 has finished for PR 17204 at commit
|
cloud-fan
reviewed
Mar 8, 2017
| * does not contain a scheme, this path will not be changed after the default | ||
| * FileSystem is changed. | ||
| */ | ||
| def makeQualifiedPath(path: String): URI = { |
There was a problem hiding this comment.
seems we can take File as parameter?
windpiger
changed the title
|
Test build #74193 has finished for PR 17204 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently there are lots of places to make the path qualified, it is better to provide a function to do this, then the code will be more simple.
How was this patch tested?
N/A