[SPARK-20013][SQL]add a newTablePath parameter for renameTable in ExternalCatalog #17341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windpiger
commented
Mar 18, 2017
| catalog.dropTable("db2", "unknown_table", ignoreIfNotExists = true, purge = false) | ||
| } | ||
|
|
||
| test("rename table") { |
There was a problem hiding this comment.
already existed in SessionCatalogSuite
windpiger
commented
Mar 18, 2017
| assert(catalog.listTables("db2").toSet == Set("tblone", "tbl2")) | ||
| } | ||
|
|
||
| test("rename table when database/table does not exist") { |
There was a problem hiding this comment.
already existed in SessionCatalogSuite
windpiger
commented
Mar 18, 2017
| } | ||
| } | ||
|
|
||
| test("rename table when destination table already exists") { |
There was a problem hiding this comment.
move to SessionCatalogSuite
windpiger
commented
Mar 18, 2017
| assert(!exists(db.locationUri)) | ||
| } | ||
|
|
||
| test("create/drop/rename table should create/delete/rename the directory") { |
There was a problem hiding this comment.
move to SessionCatalogSuite
|
Test build #74784 has finished for PR 17341 at commit
|
|
Test build #74785 has finished for PR 17341 at commit
|
|
Maybe we can close this one at first and revisit it later? |
|
We are closing it due to inactivity. please do reopen if you want to push it forward. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently when we create / rename a managed table, we should get the defaultTablePath for them in ExternalCatalog, then we have two defaultTablePath logic in its two subclass HiveExternalCatalog and InMemoryCatalog, additionally there is also a defaultTablePath in SessionCatalog, so till now we have three defaultTablePath in three classes.
we'd better to unify them up to SessionCatalog
To unify them, we should move some logic from ExternalCatalog to SessionCatalog, renameTable is one of this.
while limit to the simple parameters in renameTable
even if we move the defaultTablePath logic to SessionCatalog, we can not pass it to renameTable.
So we can add a newTablePath parameter for renameTable in ExternalCatalog
How was this patch tested?
delete some tests in ExternalCatalogSuite which already existed in SessionCatalogSuite,
and move some other tests in ExternalCatalogSuite which does not exist in SessionCatalogSuite