[SPARK-20160] [SQL] Move ParquetConversions and OrcConversions Out Of HiveSessionCatalog #17484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
hvanhovell
reviewed
Mar 30, 2017
| * When scanning or writing to non-partitioned Metastore Parquet tables, convert them to Parquet | ||
| * data source relations for better performance. | ||
| */ | ||
| case class ParquetConversions(sparkSession: SparkSession) extends Rule[LogicalPlan] { |
Contributor
There was a problem hiding this comment.
How about we pass the conf & the HiveSessionCatalog as parameters? This should be doable with the builder, and saves you from doing casting later-on
Contributor
There was a problem hiding this comment.
It might also be worth out while to create a common ancestor for these two classes.
Member
Author
There was a problem hiding this comment.
Great! Let me combine them. :)
|
Test build #75397 has finished for PR 17484 at commit
|
|
Test build #75401 has finished for PR 17484 at commit
|
Contributor
|
LGTM, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ParquetConversionsandOrcConversionsshould be treated as regularAnalyzerrules. It is not reasonable to be part ofHiveSessionCatalog. This PR also combines two rulesParquetConversionsandOrcConversionsto build a new ruleRelationConversions.After moving these two rules out of HiveSessionCatalog, the next step is to clean up, rename and move
HiveMetastoreCatalogbecause it is not related to the hive package any more.How was this patch tested?
The existing test cases