[SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider #17495

jerryshao · 2017-03-31T09:47:32Z

What changes were proposed in this pull request?

In the current Spark's HistoryServer we expected to get AccessControlException during listing all the files, but unfortunately it was not worked because we actually doesn't check the access permission and no other calls will throw such exception. What was worse is that this check will be deferred until reading files, which is not necessary and quite verbose, since it will be printed out the exception in every 10 seconds when checking the files.

So here with this fix, we actually check the read permission during listing the files, which could avoid unnecessary file read later on and suppress the verbose log.

How was this patch tested?

Add unit test to verify.

Change-Id: I7c7014ed83dbba786d90ca530380e94c086b497b

jerryshao · 2017-03-31T09:49:40Z

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

        .filter { entry =>
          try {
            val prevFileSize = fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+            fs.access(entry.getPath, FsAction.READ)


This API is tagged with @LimitedPrivate({"HDFS", "Hive"}), but I think it should be fine to call it here.

So, this API actually calls fs.getFileStatus() which is a remote call and completely unnecessary in this context, since you already have the FileStatus.

You could instead directly do the check against the FsPermission object (same way the fs.access() does after it performs the remote call).

I see, let me change it. Thanks.

Change-Id: Ie2bd075561e481266dc8047e2af604f4d6c83810

SparkQA · 2017-03-31T12:40:53Z

Test build #75431 has finished for PR 17495 at commit 63142cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

jerryshao · 2017-04-01T01:29:04Z

@tgravescs @vanzin , would you please help reviewing this PR. Thanks a lot.

jerryshao · 2017-04-07T02:06:53Z

Ping @vanzin @tgravescs again. Sorry to bother you and really appreciate your time.

SparkQA · 2017-04-07T09:49:35Z

Test build #75594 has finished for PR 17495 at commit 63142cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

tgravescs · 2017-04-07T13:56:02Z

Sorry @jerryshao I know you have a few up but I'm swamped and probably won't get to them to next week.

vanzin · 2017-04-10T17:59:27Z

core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala

 }

+  test("log without read permission should be filtered out before actual reading") {
+    class TestFsHistoryProvider extends FsHistoryProvider(createTestConf()) {


I think you'll need this from another test in this same file:

// setReadable(...) does not work on Windows. Please refer JDK-6728842. assume(!Utils.isWindows)

In fact shouldn't this test be merged with the test for SPARK-3697?

The difference of this unit test is that this UT checks whether the file is filtered out during check, and for SPARK-3697 UT, it only checks the final result, so file could be filtered out during read. Let me merge this two UTs.

vanzin · 2017-04-10T18:03:11Z

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

        .filter { entry =>
          try {
            val prevFileSize = fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+            fs.access(entry.getPath, FsAction.READ)


So, this API actually calls fs.getFileStatus() which is a remote call and completely unnecessary in this context, since you already have the FileStatus.

You could instead directly do the check against the FsPermission object (same way the fs.access() does after it performs the remote call).

Change-Id: I95fe3f765c8b66cc14bc888899f99dc8a0466e91

SparkQA · 2017-04-11T05:49:27Z

Test build #75684 has finished for PR 17495 at commit 1d1440b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2017-04-12T17:35:06Z

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

          try {
            val prevFileSize = fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+
+            def canAccess = {


Return type? Also I'd make this a top-level method (with the entry and action as parameters), maybe even in SparkHadoopUtil... just to avoid the deeply-nested method declaration. That allows you to easily write a unit test for it (yay!).

vanzin · 2017-04-12T17:35:46Z

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

+              val perm = entry.getPermission
+              val ugi = UserGroupInformation.getCurrentUser
+              val user = ugi.getShortUserName
+              val groups = ugi.getGroupNames


nit: this is only used in one place, just inline the call.

vanzin · 2017-04-12T17:37:29Z

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

+              } else if (perm.getOtherAction.implies(FsAction.READ)) {
+                true
+              } else {
+                throw new AccessControlException(s"Permission denied: user=$user, " +


Why throw an exception instead of returning false? That makes the function's interface weird.

You could just log the access issue here if you want, and then you can even remove the try..catch.

vanzin · 2017-04-12T17:42:19Z

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

+              val ugi = UserGroupInformation.getCurrentUser
+              val user = ugi.getShortUserName
+              val groups = ugi.getGroupNames
+              if (user == entry.getOwner && perm.getUserAction.implies(FsAction.READ)) {


This code is not correct. The code in Hadoop's FileSystem.checkAccessPermissions is slightly different and actually correct.

For example, if you have a file with permissions 066 and your user matches the owner, you do not have permission to read the file, even if you belong to a group that has permissions to read it. Your code allows that user to read that file.

e.g.

$ sudo ls -la /tmp/test total 132 d---rwxrwx 2 vanzin vanzin 4096 Abr 12 10:30 . drwxrwxrwt 78 root root 126976 Abr 12 10:30 .. $ ls /tmp/test ls: cannot open directory '/tmp/test': Permission denied

There's also an issue with superusers (they should always have permissions), but then the Hadoop library also has that problem, so maybe we can ignore that one.

Sorry about it. Let me fix it.

Change-Id: I38a5491e555496004204bf99634f7147dac6c642

SparkQA · 2017-04-13T06:06:13Z

Test build #75755 has finished for PR 17495 at commit 9447011.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

jerryshao · 2017-04-13T06:12:03Z

Jenkins, retest this please.

SparkQA · 2017-04-13T06:12:35Z

Test build #75758 has started for PR 17495 at commit 9447011.

jerryshao · 2017-04-13T12:40:55Z

Jenkins, test this please.

SparkQA · 2017-04-13T15:21:38Z

Test build #75774 has finished for PR 17495 at commit 9447011.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2017-04-17T21:22:13Z

core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala

+    val path = new Path(logFile2.toURI)
+    val fs = path.getFileSystem(SparkHadoopUtil.get.conf)
+    val status = fs.getFileStatus(path)
+    SparkHadoopUtil.get.checkAccessPermission(status, FsAction.READ) should be (true)


Why are these tests here? There's no SparkHadoopUtilSuite currently but it makes a lot more sense to create one, since that's where the code lives.

You also don't need to reference real files here; you can create custom FileStatus objects to test the behavior you want (the constructors are public and provide all the parameters you need).

Thanks @vanzin , I will update the code.

Change-Id: Ib9ac4be0a896531a529c260197431df1c3adf77a

SparkQA · 2017-04-18T04:32:36Z

Test build #75884 has started for PR 17495 at commit 4d3838a.

jerryshao · 2017-04-18T07:18:54Z

Jenkins, retest this please.

SparkQA · 2017-04-18T09:28:44Z

Test build #75890 has finished for PR 17495 at commit 4d3838a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkHadoopUtilSuite extends SparkFunSuite with Matchers

jerryshao · 2017-04-18T12:39:29Z

Jenkins, retest this please.

SparkQA · 2017-04-18T15:22:47Z

Test build #75897 has finished for PR 17495 at commit 4d3838a.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkHadoopUtilSuite extends SparkFunSuite with Matchers

vanzin · 2017-04-18T17:07:58Z

core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala

+class SparkHadoopUtilSuite extends SparkFunSuite with Matchers {
+  test("check file permission") {
+    import FsAction._
+    val user = UserGroupInformation.getCurrentUser.getShortUserName


Instead of using getCurrentUser, I think it would be safer to use createUserForTesting + ugi.doAs. That lets you define the user name and the groups and thus avoids possible clashes with the OS configuration.

Yeah, that would be better, thanks for the suggestion.

Change-Id: Iafc17472e44a511402a3faa5e1889fa445b3c386

SparkQA · 2017-04-19T04:13:39Z

Test build #75924 has finished for PR 17495 at commit ab5117b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2017-04-19T17:53:18Z

core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala

+    val groups = UserGroupInformation.getCurrentUser.getGroupNames
+    require(!groups.isEmpty)
+
+    val testUser = user + "-" + Random.nextInt(100)


You don't need to get the current user just for this... just create a random user name.

Change-Id: Ic9851b569da3458895e7c7ea8a5474941c466585

SparkQA · 2017-04-20T06:12:35Z

Test build #75965 has finished for PR 17495 at commit b36fa75.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

vanzin · 2017-04-20T23:00:56Z

LGTM, merging to master / 2.2.

…sHistoryProvider ## What changes were proposed in this pull request? In the current Spark's HistoryServer we expected to get `AccessControlException` during listing all the files, but unfortunately it was not worked because we actually doesn't check the access permission and no other calls will throw such exception. What was worse is that this check will be deferred until reading files, which is not necessary and quite verbose, since it will be printed out the exception in every 10 seconds when checking the files. So here with this fix, we actually check the read permission during listing the files, which could avoid unnecessary file read later on and suppress the verbose log. ## How was this patch tested? Add unit test to verify. Author: jerryshao <[email protected]> Closes #17495 from jerryshao/SPARK-20172. (cherry picked from commit 592f5c8) Signed-off-by: Marcelo Vanzin <[email protected]>

…sHistoryProvider ## What changes were proposed in this pull request? In the current Spark's HistoryServer we expected to get `AccessControlException` during listing all the files, but unfortunately it was not worked because we actually doesn't check the access permission and no other calls will throw such exception. What was worse is that this check will be deferred until reading files, which is not necessary and quite verbose, since it will be printed out the exception in every 10 seconds when checking the files. So here with this fix, we actually check the read permission during listing the files, which could avoid unnecessary file read later on and suppress the verbose log. ## How was this patch tested? Add unit test to verify. Author: jerryshao <[email protected]> Closes apache#17495 from jerryshao/SPARK-20172.

Add file permission check in listing files

10d254b

Change-Id: I7c7014ed83dbba786d90ca530380e94c086b497b

jerryshao commented Mar 31, 2017

View reviewed changes

Also add logics to handle other exceptions

63142cc

Change-Id: Ie2bd075561e481266dc8047e2af604f4d6c83810

jerryshao changed the title ~~[SPARK-20172] Add file permission check when listing files in FsHistoryProvider~~ [SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider Mar 31, 2017

vanzin requested changes Apr 10, 2017

View reviewed changes

Address the comments

1d1440b

Change-Id: I95fe3f765c8b66cc14bc888899f99dc8a0466e91

vanzin requested changes Apr 12, 2017

View reviewed changes

Further address the comments

9447011

Change-Id: I38a5491e555496004204bf99634f7147dac6c642

vanzin reviewed Apr 17, 2017

View reviewed changes

Address the comments to change the UT

4d3838a

Change-Id: Ib9ac4be0a896531a529c260197431df1c3adf77a

vanzin reviewed Apr 18, 2017

View reviewed changes

Using test UGI to mimic current user and groups

ab5117b

Change-Id: Iafc17472e44a511402a3faa5e1889fa445b3c386

vanzin reviewed Apr 19, 2017

View reviewed changes

Address the comments

b36fa75

Change-Id: Ic9851b569da3458895e7c7ea8a5474941c466585

asfgit closed this in 592f5c8 Apr 20, 2017

[SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider #17495

[SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider #17495

Uh oh!

Conversation

jerryshao commented Mar 31, 2017

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Mar 31, 2017

Uh oh!

jerryshao commented Apr 1, 2017

Uh oh!

jerryshao commented Apr 7, 2017

Uh oh!

SparkQA commented Apr 7, 2017

Uh oh!

tgravescs commented Apr 7, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Apr 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Apr 13, 2017

Uh oh!

jerryshao commented Apr 13, 2017

Uh oh!

SparkQA commented Apr 13, 2017

Uh oh!

jerryshao commented Apr 13, 2017

Uh oh!

SparkQA commented Apr 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Apr 18, 2017

Uh oh!

jerryshao commented Apr 18, 2017

Uh oh!

SparkQA commented Apr 18, 2017

Uh oh!

jerryshao commented Apr 18, 2017

Uh oh!

SparkQA commented Apr 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Apr 19, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Apr 20, 2017

Uh oh!

vanzin commented Apr 20, 2017

Uh oh!

Reviewers

Assignees