[SPARK-20036][DOC] Note incompatible dependencies on org.apache.kafka artifacts #17675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies on org.apache.kafka artifacts
srowen
reviewed
Apr 18, 2017
| artifactId = spark-streaming-kafka-0-10_{{site.SCALA_BINARY_VERSION}} | ||
| version = {{site.SPARK_VERSION_SHORT}} | ||
|
|
||
| **Do not** manually add dependencies on org.apache.kafka artifacts (e.g. kafka-clients). The spark-streaming-kafka-0-10 artifact has the appropriate transitive dependencies already, and different versions may be incompatible in hard to diagnose ways. |
Member
There was a problem hiding this comment.
I suppose that if the app is using kafka APIs directly it should declare a direct dependency on it, but, harmonize the versions. That said, that's error prone, so this seems OK. If you make further changes to the text here can you back-tick the artifact names for readability?
srowen
approved these changes
Apr 18, 2017
|
Test build #75913 has finished for PR 17675 at commit
|
|
Test build #75915 has finished for PR 17675 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Apr 19, 2017
… artifacts ## What changes were proposed in this pull request? Note that you shouldn't manually add dependencies on org.apache.kafka artifacts ## How was this patch tested? Doc only change, did jekyll build and looked at the page. Author: cody koeninger <[email protected]> Closes #17675 from koeninger/SPARK-20036. (cherry picked from commit 71a8e9d) Signed-off-by: Sean Owen <[email protected]>
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
… artifacts ## What changes were proposed in this pull request? Note that you shouldn't manually add dependencies on org.apache.kafka artifacts ## How was this patch tested? Doc only change, did jekyll build and looked at the page. Author: cody koeninger <[email protected]> Closes apache#17675 from koeninger/SPARK-20036.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Note that you shouldn't manually add dependencies on org.apache.kafka artifacts
How was this patch tested?
Doc only change, did jekyll build and looked at the page.