[SPARK-20494] Implement UDF array_unique in Spark with codegen #17778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hi @janewangfb, it looks we need a JIRA, better PR title and PR description. Please check out http://spark.apache.org/contributing.html. |
|
Why does this need to be added? If it isn't a standard function somewhere it probably doesn't need to be in Spark |
|
@srowen We have array_contains UDF. I think it is nice to have one that removes all the duplicated elements. |
janewangfb
changed the title
|
@janewangfb that's because |
|
We should close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add UDF array_unique which return a new array with all the duplicated elements in the original array removed.
How was this patch tested?
Added various unittests in collectionExpressionsSuite.scala and also in spark-shell, created tables with columns of array type and inserted values with duplicated array elements, ran queries with UDF and verified the results.