[SPARK-20047][FOLLOWUP][ML] Constrained Logistic Regression follow up #17829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbtsai
approved these changes
May 2, 2017
|
Test build #76371 has finished for PR 17829 at commit
|
|
LGTM. Wait for more reviews. Thanks. |
|
Merged into master and branch-2.0, thanks for reviewing. If there are more comments, I can address them in 2.2 QA PRs. Thanks. |
asfgit
pushed a commit
that referenced
this pull request
May 4, 2017
## What changes were proposed in this pull request? Address some minor comments for #17715: * Put bound-constrained optimization params under expertParams. * Update some docs. ## How was this patch tested? Existing tests. Author: Yanbo Liang <[email protected]> Closes #17829 from yanboliang/spark-20047-followup. (cherry picked from commit c5dceb8) Signed-off-by: Yanbo Liang <[email protected]>
|
Awesome, thank you! |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
## What changes were proposed in this pull request? Address some minor comments for apache#17715: * Put bound-constrained optimization params under expertParams. * Update some docs. ## How was this patch tested? Existing tests. Author: Yanbo Liang <[email protected]> Closes apache#17829 from yanboliang/spark-20047-followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address some minor comments for #17715:
How was this patch tested?
Existing tests.