[SPARK-20555][SQL] Fix mapping of Oracle DECIMAL types to Spark types #17830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
gatorsmile
reviewed
Jun 13, 2017
| assert(values.getFloat(4).equals(doubleVal.toFloat)) | ||
| assert(values.getInt(5).equals(byteVal.toInt)) | ||
| assert(values.getInt(6).equals(shortVal.toInt)) | ||
| assert(values.getDecimal(0).compareTo(BigDecimal.valueOf(booleanVal ? 1 : 0)) == 0) |
There was a problem hiding this comment.
This does not work. The conditional operator ? : is not supported by Scala.
|
Test build #77952 has finished for PR 17830 at commit
|
|
ping @gaborfeher |
|
Hi, thanks for the review! I definitely want to continue, but I'll only have more time to look into this next week. (I don't exactly know how I ended up with that broken test, because I was able to run some tests locally. I think, at least.) |
|
This is a pretty serious bug. Let me resolve the failure as a separate PR. Will give all the credits to you when we merging the PR. Thank you for your fix! |
|
Thank you, I am happy to see the issue is taken care of! (I don't know the customs here, we can also share the credit.) |
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2017
… in read path ## What changes were proposed in this pull request? This PR is to revert some code changes in the read path of #14377. The original fix is #17830 When merging this PR, please give the credit to gaborfeher ## How was this patch tested? Added a test case to OracleIntegrationSuite.scala Author: Gabor Feher <[email protected]> Author: gatorsmile <[email protected]> Closes #18408 from gatorsmile/OracleType. (cherry picked from commit b837bf9) Signed-off-by: gatorsmile <[email protected]>
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Jun 24, 2017
… in read path ## What changes were proposed in this pull request? This PR is to revert some code changes in the read path of apache#14377. The original fix is apache#17830 When merging this PR, please give the credit to gaborfeher ## How was this patch tested? Added a test case to OracleIntegrationSuite.scala Author: Gabor Feher <[email protected]> Author: gatorsmile <[email protected]> Closes apache#18408 from gatorsmile/OracleType.
|
@gaborfeher Since the PR has been merged, could you please close it? Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Jun 24, 2017
… in read path This PR is to revert some code changes in the read path of #14377. The original fix is #17830 When merging this PR, please give the credit to gaborfeher Added a test case to OracleIntegrationSuite.scala Author: Gabor Feher <[email protected]> Author: gatorsmile <[email protected]> Closes #18408 from gatorsmile/OracleType.
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
… in read path ## What changes were proposed in this pull request? This PR is to revert some code changes in the read path of apache#14377. The original fix is apache#17830 When merging this PR, please give the credit to gaborfeher ## How was this patch tested? Added a test case to OracleIntegrationSuite.scala Author: Gabor Feher <[email protected]> Author: gatorsmile <[email protected]> Closes apache#18408 from gatorsmile/OracleType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change removes the custom code from
OracleDialect, that was mapping some of Oracle'sDECIMAL(X, Y)types toBooleanType,IntegerType,LongTypeorFloatType.How was this patch tested?
I used the following command to run the docker-based integration tests: