Skip to content

[SPARK-2866][SQL] Support attributes in ORDER BY that aren't in SELECT #1795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[SPARK-2866][SQL] Support attributes in ORDER BY that aren't in SELECT #1795

wants to merge 4 commits into from

Conversation

marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Aug 6, 2014

Minor refactoring to allow resolution either using a nodes input or output.

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1795. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17967/consoleFull

chenghao-intel
chenghao-intel reviewed Aug 6, 2014
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces before and after @

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1795. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17979/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1795:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17967/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1795:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17979/consoleFull

@marmbrus
Copy link
Contributor Author

marmbrus commented Aug 6, 2014

Thanks for the comments. I've merged this into master and branch 1.1

asfgit pushed a commit that referenced this pull request Aug 6, 2014
@marmbrus
[SPARK-2866][SQL] Support attributes in ORDER BY that aren't in SELECT
936f61e 
Minor refactoring to allow resolution either using a nodes input or output.

Author: Michael Armbrust <[email protected]>

Closes #1795 from marmbrus/ordering and squashes the following commits:

237f580 [Michael Armbrust] style
74d833b [Michael Armbrust] newline
705d963 [Michael Armbrust] Add a rule for resolving ORDER BY expressions that reference attributes not present in the SELECT clause.
82cabda [Michael Armbrust] Generalize attribute resolution.

(cherry picked from commit 1d70c4f)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 1d70c4f Aug 6, 2014
@marmbrus marmbrus deleted the ordering branch August 27, 2014 20:47
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@marmbrus @conviva-zz
[SPARK-2866][SQL] Support attributes in ORDER BY that aren't in SELECT
1127d37 
Minor refactoring to allow resolution either using a nodes input or output.

Author: Michael Armbrust <[email protected]>

Closes apache#1795 from marmbrus/ordering and squashes the following commits:

237f580 [Michael Armbrust] style
74d833b [Michael Armbrust] newline
705d963 [Michael Armbrust] Add a rule for resolving ORDER BY expressions that reference attributes not present in the SELECT clause.
82cabda [Michael Armbrust] Generalize attribute resolution.
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
@sunchao
rdar://110874630 Bump Boson to 0.3.12 (apache#1795)
6603d2d 
- Patch list: https://github.pie.apple.com/pie/boson/compare/f2ae3c5ea901b5e631f991928332b6f9667e585d...563b26844c30f328e04bac9ab3319dfae826b48b
- Release notes: https://github.pie.apple.com/pie/boson/releases/tag/0.3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marmbrus @SparkQA @chenghao-intel