[SPARK-20815] [SPARKR] NullPointerException in RPackageUtils#checkManifestForR #18040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins, ok to test |
|
Test build #77128 has finished for PR 18040 at commit
|
felixcheung
reviewed
May 21, 2017
| } | ||
| mani | ||
| mani | ||
| } else null |
There was a problem hiding this comment.
I think typically Spark style is to have the else statement in separate line enclosed with {} like
} else {
null
}
| val jarStream = new JarOutputStream(jarFileStream, manifest) | ||
| val jarStream = if (manifest != null) { | ||
| new JarOutputStream(jarFileStream, manifest) | ||
| } else new JarOutputStream(jarFileStream) |
|
@jrshust would you have a chance to address a few minor comments? |
|
@felixcheung yep sorry will address today! |
|
Test build #77195 has started for PR 18040 at commit |
|
hmm that's odd |
|
Yeah I'm a bit confused the last build was fine and this one just had style changes. What are the next steps here? Is that a red herring or was it actually aborted? |
|
Jenkins, retest this please |
|
it looks like build jobs are killed, let's try again |
|
Test build #77205 has finished for PR 18040 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 23, 2017
…festForR ## What changes were proposed in this pull request? - Add a null check to RPackageUtils#checkManifestForR so that jars w/o manifests don't NPE. ## How was this patch tested? - Unit tests and manual tests. Author: James Shuster <[email protected]> Closes #18040 from jrshust/feature/r-package-utils. (cherry picked from commit 4dbb63f) Signed-off-by: Felix Cheung <[email protected]>
|
merged to master/2.2, thanks! |
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
…festForR ## What changes were proposed in this pull request? - Add a null check to RPackageUtils#checkManifestForR so that jars w/o manifests don't NPE. ## How was this patch tested? - Unit tests and manual tests. Author: James Shuster <[email protected]> Closes apache#18040 from jrshust/feature/r-package-utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?