[SPARK-20399][SQL][Follow-up] Add a config to fallback string literal parsing consistent with old sql parser behavior #18048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
SPARK-20399-follow-up
branch
from
b38aa71 to
2d5c11d
Compare
|
Test build #77147 has started for PR 18048 at commit |
viirya
force-pushed
the
SPARK-20399-follow-up
branch
from
2d5c11d to
9af9caf
Compare
|
Test build #77148 has started for PR 18048 at commit |
srowen
approved these changes
May 21, 2017
|
ping @cloud-fan |
|
retest this please |
|
Test build #77218 has finished for PR 18048 at commit
|
|
thanks, merging to master/2.2! |
asfgit
pushed a commit
that referenced
this pull request
May 23, 2017
… parsing consistent with old sql parser behavior ## What changes were proposed in this pull request? As srowen pointed in 609ba5f#commitcomment-22221259, the previous tests are not proper. This follow-up is going to fix the tests. ## How was this patch tested? Jenkins tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Liang-Chi Hsieh <[email protected]> Closes #18048 from viirya/SPARK-20399-follow-up. (cherry picked from commit 442287a) Signed-off-by: Wenchen Fan <[email protected]>
|
Thanks @cloud-fan and @srowen . |
liyichao
pushed a commit
to liyichao/spark
that referenced
this pull request
May 24, 2017
… parsing consistent with old sql parser behavior ## What changes were proposed in this pull request? As srowen pointed in apache@609ba5f#commitcomment-22221259, the previous tests are not proper. This follow-up is going to fix the tests. ## How was this patch tested? Jenkins tests. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Liang-Chi Hsieh <[email protected]> Closes apache#18048 from viirya/SPARK-20399-follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As @srowen pointed in 609ba5f#commitcomment-22221259, the previous tests are not proper.
This follow-up is going to fix the tests.
How was this patch tested?
Jenkins tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.