[Web UI] Remove no need loop in JobProgressListener #18130
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
srowen
reviewed
May 27, 2017
| // If there's no information for a stage, store the StageInfo received from the scheduler | ||
| // so that we can display stage descriptions for pending stages: | ||
| for (stageInfo <- jobStart.stageInfos) { | ||
| stageIdToActiveJobIds.getOrElseUpdate(stageInfo.stageId, |
There was a problem hiding this comment.
It's not immediately clear to me they're equivalent. They'd have to contain the same set of stage IDs. Is it worth it?
|
It seems to me that the older versions of |
|
There's a JIRA planning to remove this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I found it's unnecessary to use the same loop twice, so changed them into one. It's a little change...
How was this patch tested?
./build/mvn -P... -Dtest=none -DwildcardSuites=org.apache.spark.ui.jobs.JobProgressListenerSuite test