[SPARK-21132] [SQL] DISTINCT modifier of function arguments should not be silently ignored #18340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #78220 has finished for PR 18340 at commit
|
|
+1, LGTM. |
|
cc @cloud-fan |
asfgit
pushed a commit
that referenced
this pull request
Jun 19, 2017
… be silently ignored ### What changes were proposed in this pull request? We should not silently ignore `DISTINCT` when they are not supported in the function arguments. This PR is to block these cases and issue the error messages. ### How was this patch tested? Added test cases for both regular functions and window functions Author: Xiao Li <[email protected]> Closes #18340 from gatorsmile/firstCount. (cherry picked from commit 9413b84) Signed-off-by: Wenchen Fan <[email protected]>
|
LGTM, merging to master/2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We should not silently ignore
DISTINCTwhen they are not supported in the function arguments. This PR is to block these cases and issue the error messages.How was this patch tested?
Added test cases for both regular functions and window functions