Skip to content

Conversation

@dgai91
Copy link

@dgai91 dgai91 commented Jun 20, 2017

What changes were proposed in this pull request?

add two function cosineSimilarity and doc2Vector

How was this patch tested?

i tested it myself and it worked well but maybe the bVecter in doc2Vector can be a param,i will update it soon
i have updated it

the word2vec model needs an independent function to calculate the cosine similarity.we also desire a function to transform the single document to a vector.so i contribute the two function.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@srowen
Copy link
Member

srowen commented Jun 20, 2017

@lawlietAi you should close this and read http://spark.apache.org/contributing.html . This doesn't describe the purpose or need for this change

@dgai91
Copy link
Author

dgai91 commented Jun 21, 2017

@srowen sorry, i'll familiar this documentation on my spare time. thanks for your patience

@srowen srowen mentioned this pull request Jun 25, 2017
@gatorsmile
Copy link
Member

Really appreciate your contribution! Sorry, based on the comment, we might need to close this PR, but please submit more PRs in the future. Thanks again!

@asfgit asfgit closed this in b32bd00 Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants