[SPARK-21164] [SQL] Remove isTableSample from Sample and isGenerated from Alias and AttributeReference #18379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #78399 has finished for PR 18379 at commit
|
Contributor
|
Shouldn't we remove all the |
Member
Author
|
@hvanhovell Yes! Let me remove them in this PR too. : ) |
|
Test build #78402 has finished for PR 18379 at commit
|
gatorsmile
changed the title
Contributor
|
LGTM - pending jenkins. |
|
Test build #78535 has finished for PR 18379 at commit
|
|
Test build #78536 has finished for PR 18379 at commit
|
Member
Author
|
Thanks! Merging to master. |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
…rom Alias and AttributeReference ## What changes were proposed in this pull request? `isTableSample` and `isGenerated ` were introduced for SQL Generation respectively by apache#11148 and apache#11050 Since SQL Generation is removed, we do not need to keep `isTableSample`. ## How was this patch tested? The existing test cases Author: Xiao Li <[email protected]> Closes apache#18379 from gatorsmile/CleanSample.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
isTableSampleandisGeneratedwere introduced for SQL Generation respectively by #11148 and #11050Since SQL Generation is removed, we do not need to keep
isTableSample.How was this patch tested?
The existing test cases