SPARK-22021 #19244
Closed
SPARK-22021 #19244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Merging from upstream
srowen
reviewed
Sep 15, 2017
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Just implement Transformer. This adds very little
srowen
reviewed
Sep 16, 2017
| import org.apache.spark.sql.types.StructField | ||
| import org.apache.spark.sql.types.StructType | ||
|
|
||
| import javax.script.ScriptEngineManager |
Member
There was a problem hiding this comment.
I think introducing Javascript is a non-starter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This adds a new feature transformer which will take a javascript function and based on the logic provided in that, derives new features.
How was this patch tested?
There is proper unit test written for this transformer and also it's been testing in local and yarn-client mode.
Please review http://spark.apache.org/contributing.html before opening a pull request.