[SPARK-22092] Reallocation in OffHeapColumnVector.reserveInternal corrupts struct and array data #19323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rupts struct and array data `OffHeapColumnVector.reserveInternal()` will only copy already inserted values during reallocation if `data != null`. In vectors containing arrays or structs this is incorrect, since there field `data` is not used at all. We need to check `nulls` instead. Adds new tests to `ColumnVectorSuite` that reproduce the errors. Author: Ala Luszczak <[email protected]> Closes apache#19308 from ala/vector-realloc. (cherry picked from commit d2b2932) Signed-off-by: Ala Luszczak <[email protected]>
|
Test build #82085 has started for PR 19323 at commit |
|
LGTM |
|
retest this please |
|
Test build #82095 has finished for PR 19323 at commit
|
|
merging to 2.2. Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Sep 23, 2017
…rupts struct and array data `OffHeapColumnVector.reserveInternal()` will only copy already inserted values during reallocation if `data != null`. In vectors containing arrays or structs this is incorrect, since there field `data` is not used at all. We need to check `nulls` instead. Adds new tests to `ColumnVectorSuite` that reproduce the errors. Author: Ala Luszczak <[email protected]> Closes #19323 from ala/port-vector-realloc.
|
@ala can you close this one? The merge script does not do that for backports. |
|
@hvanhovell Sure. Thanks! |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…rupts struct and array data `OffHeapColumnVector.reserveInternal()` will only copy already inserted values during reallocation if `data != null`. In vectors containing arrays or structs this is incorrect, since there field `data` is not used at all. We need to check `nulls` instead. Adds new tests to `ColumnVectorSuite` that reproduce the errors. Author: Ala Luszczak <[email protected]> Closes apache#19323 from ala/port-vector-realloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OffHeapColumnVector.reserveInternal()will only copy already inserted values during reallocation ifdata != null. In vectors containing arrays or structs this is incorrect, since there fielddatais not used at all. We need to checknullsinstead.Adds new tests to
ColumnVectorSuitethat reproduce the errors.