Skip to content

Conversation

@liancheng
Copy link
Contributor

This PR tries to catch ClassNotFoundException within SparkSubmit and exit with a special status code. Then we check the exit status within scripts to provide more friendly error message.

@SparkQA
Copy link

SparkQA commented Aug 14, 2014

QA tests have started for PR 1944. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18539/consoleFull

@liancheng
Copy link
Contributor Author

@patrick This PR conflicts with #1886, we can merge #1886 first, and then I'll rebase mine.

@pwendell
Copy link
Contributor

Sounds good - it will also conflict (logically) with #2006

@marmbrus
Copy link
Contributor

@liancheng, can you please update this to fix the conflict and say -Phive now that #2006 has been merged?

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 1944 at commit 9c894d3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have started for PR 1944 at commit 81b43a8.

  • This patch merges cleanly.

@liancheng
Copy link
Contributor Author

@marmbrus Rebased. Also included the -S command line option fix in #1886, since we should include this in 1.1 release and unfortunately #1886 conflicts with master again (@sarutak I'm sorry...).

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 1944 at commit 9c894d3.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • eval "$FWDIR"/bin/spark-submit --class $CLASS $
    • eval "$FWDIR"/bin/spark-submit --class $CLASS $

@SparkQA
Copy link

SparkQA commented Aug 21, 2014

QA tests have finished for PR 1944 at commit 81b43a8.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • "$FWDIR"/bin/spark-submit --class $CLASS "$
    • "$FWDIR"/bin/spark-submit --class $CLASS "$

@sarutak
Copy link
Member

sarutak commented Aug 21, 2014

I'll rebase this PR to #1886 after merging this PR.

@liancheng
Copy link
Contributor Author

@marmbrus @pwendell I think this is good to go.

@liancheng liancheng changed the title [SPARK-3026][SQL] Report better error message when running JDBC/CLI without hive-thriftserver profile enabled [SPARK-3026][SQL] Report better error message when running JDBC/CLI without hive profile enabled Aug 22, 2014
@marmbrus
Copy link
Contributor

@liancheng can you fix the merge problems?

@liancheng
Copy link
Contributor Author

@marmbrus Please merge #1886 first, otherwise it has to be rebased for the 3rd time. Then I'll rebase this one.

@liancheng
Copy link
Contributor Author

@marmbrus Just realized we don't need to merge this PR anymore, since @sarutak has already merged this one into #1886. Closing.

@liancheng liancheng closed this Aug 27, 2014
asfgit pushed a commit that referenced this pull request Sep 18, 2014
…NotFoundExcepti...

...on

As improvement of #1944, we should use more special exit code to represent ClassNotFoundException.

Author: WangTaoTheTonic <[email protected]>

Closes #2421 from WangTaoTheTonic/classnotfoundExitCode and squashes the following commits:

645a22a [WangTaoTheTonic] Serveral typos to trigger Jenkins
d6ae559 [WangTaoTheTonic] use 101 instead
a2d6465 [WangTaoTheTonic] use 127 instead
fbb232f [WangTaoTheTonic] Using a special exit code instead of 1 to represent ClassNotFoundException
@liancheng liancheng deleted the spark-3026 branch September 24, 2014 00:07
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants