[SPARK-22549][SQL] Fix 64KB JVM bytecode limit problem with concat_ws #19777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #83978 has finished for PR 19777 at commit
|
cloud-fan
reviewed
Nov 20, 2017
| val varargNum = ctx.freshName("varargNum") | ||
| ctx.addMutableState("int", varargNum, "") | ||
| val idxInVararg = ctx.freshName("idxInVararg") | ||
| ctx.addMutableState("int", idxInVararg, "") |
Contributor
There was a problem hiding this comment.
can we do better? I think we can avoid these global variables.
Member
Author
There was a problem hiding this comment.
Sure, you are right. Let me do it later.
cloud-fan
reviewed
Nov 20, 2017
| """ | ||
| }, | ||
| _.mkString(s"$varargNum += ", s";\n$varargNum += ", ";")) | ||
| val varargBuilds = ctx.splitExpressions(varargBuild, "varargBuildsConcatWs", |
Contributor
There was a problem hiding this comment.
shall we optimize for eval.isNull == "true" in varargCount and varargBuild? since you already did it for the all string cases.
|
Test build #84030 has finished for PR 19777 at commit
|
|
Test build #84034 has finished for PR 19777 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 21, 2017
## What changes were proposed in this pull request? This PR changes `concat_ws` code generation to place generated code for expression for arguments into separated methods if these size could be large. This PR resolved the case of `concat_ws` with a lot of argument ## How was this patch tested? Added new test cases into `StringExpressionsSuite` Author: Kazuaki Ishizaki <[email protected]> Closes #19777 from kiszk/SPARK-22549. (cherry picked from commit 41c6f36) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
|
thanks, merging to master/2.2! |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request? This PR changes `concat_ws` code generation to place generated code for expression for arguments into separated methods if these size could be large. This PR resolved the case of `concat_ws` with a lot of argument ## How was this patch tested? Added new test cases into `StringExpressionsSuite` Author: Kazuaki Ishizaki <[email protected]> Closes apache#19777 from kiszk/SPARK-22549. (cherry picked from commit 41c6f36) Signed-off-by: Wenchen Fan <[email protected]>
srowen
reviewed
Aug 2, 2018
| val args = ctx.freshName("args") | ||
|
|
||
| val inputs = strings.zipWithIndex.map { case (eval, index) => | ||
| if (eval.isNull != "true") { |
Member
There was a problem hiding this comment.
@kiszk I was looking at build warnings and it notes that this compares a ExprValue and String and they will always not be equal. Should it be eval.isNull.code != "true" maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR changes
concat_wscode generation to place generated code for expression for arguments into separated methods if these size could be large.This PR resolved the case of
concat_wswith a lot of argumentHow was this patch tested?
Added new test cases into
StringExpressionsSuite