[SPARK-22775][SQL] move dictionary related APIs from ColumnVector to WritableColumnVector #19970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #84871 has finished for PR 19970 at commit
|
|
retest this please |
|
Test build #84881 has finished for PR 19970 at commit
|
ueshin
reviewed
Dec 14, 2017
There was a problem hiding this comment.
We can simplify reserveDictionaryIds() at WritableColumnVector.java#L659 as well.
Otherwise, LGTM.
| /** | ||
| * Returns a utility object to get structs. | ||
| * provided to keep API compatibility with InternalRow for code generation | ||
| * A special version of {@link #getShort(int)}, which is only used as an adapter for Spark codegen |
There was a problem hiding this comment.
getStruct(int) instead of getShort(int)?
|
Test build #84891 has finished for PR 19970 at commit
|
|
retest this pease |
kiszk
reviewed
Dec 14, 2017
|
|
||
| /** | ||
| * Returns the dictionary Id for rowId. | ||
| * This should only be called when the ColumnVector is dictionaryIds. |
There was a problem hiding this comment.
ColumnVector -> WritableColumnVector
There was a problem hiding this comment.
when dictionaryIds has WritableColumnVector.?
|
LGTM except a few comments for wording |
|
Test build #84903 has finished for PR 19970 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
These dictionary related APIs are special to
WritableColumnVectorand should not be inColumnVector, which will be public soon.How was this patch tested?
existing tests