Skip to content

Conversation

@mcavdar
Copy link
Contributor

@mcavdar mcavdar commented Dec 15, 2017

What changes were proposed in this pull request?

Easy fix in the link.

How was this patch tested?

Tested manually

@srowen
Copy link
Member

srowen commented Dec 15, 2017

This is fine @mcavdar . While we're at it, there's a link to https://mesos.apache.org/documentation/latest/mesos-frameworks/ that looks dead too -- do you know where that goes?

Also -- just a pet peeve of mine -- I think we can use HTTPS URLs wherever supported. Not worth changing for its own sake, but might be worth it if changing these links for other reasons.

And you're welcome to run a link checker to discover more dead links. I know there are more.

@mcavdar
Copy link
Contributor Author

mcavdar commented Dec 15, 2017

It has already been fixed. 01f183e
I'm running a link checker to find and fix more.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 16, 2017

Maybe it's not quite related but do you mind if I ask to fix the below too?

</div>
</div>
### Run SQL on files directly

to (just adding a newline)

 </div> 
 </div> 

 ### Run SQL on files directly 

because it currently could break doc rendering as below:

@mcavdar
Copy link
Contributor Author

mcavdar commented Dec 17, 2017

@srowen Here is all broken links, it may be useful. Each line contains broken link and parent page (separated by tab). About 75-100 broken links are related to "http(s)://spark.apache.org/docs/latest".

@SparkQA
Copy link

SparkQA commented Dec 17, 2017

Test build #4012 has finished for PR 19996 at commit 029f676.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 17, 2017

Merged to master

@asfgit asfgit closed this in 77988a9 Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants