[SPARK-22874][PYSPARK][SQL] Modify checking pandas version to use LooseVersion. #20054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85303 has finished for PR 20054 at commit
|
|
Test build #85304 has finished for PR 20054 at commit
|
|
Test build #85305 has finished for PR 20054 at commit
|
HyukjinKwon
reviewed
Dec 22, 2017
python/pyspark/sql/utils.py
Outdated
| return jarr | ||
|
|
||
|
|
||
| def _require_minimum_pandas_version(): |
Member
There was a problem hiding this comment.
Ohh. BTW, I think we can just name it _require_minimum_pandas_version -> require_minimum_pandas_version and _require_minimum_pyarrow_version -> require_minimum_pyarrow_version. It's fine as is too to me.
Member
Author
There was a problem hiding this comment.
Sounds good. I'll update them. Thanks!
|
Test build #85306 has finished for PR 20054 at commit
|
Member
|
Still LGTM |
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently we check pandas version by capturing if
ImportErrorfor the specific imports is raised or not but we can compareLooseVersionof the version strings as the same as we're checking pyarrow version.How was this patch tested?
Existing tests.