Skip to content

[SPARK-23408][SS] Synchronize successive AddDataMemory actions in StreamTest. #20646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-23408][SS] Synchronize successive AddDataMemory actions in StreamTest. #20646

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d540be6
just use synchronization
jose-torres Feb 20, 2018
d91c55f
Merge branch 'master' of https://github.com/apache/spark into flaky
jose-torres Feb 20, 2018
dce075f
fix merge
jose-torres Feb 20, 2018
1df90e7
fix indent
jose-torres Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,25 @@ trait StreamTest extends QueryTest with SharedSQLContext with TimeLimits with Be
val defaultCheckpointLocation =
Utils.createTempDir(namePrefix = "streaming.metadata").getCanonicalPath
try {
startedTest.foreach { action =>
val actionIterator = startedTest.iterator.buffered
while (actionIterator.hasNext) {
// Synchronize sequential addDataMemory actions.
Copy link
Contributor

@tdas tdas Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Synchronize --> // Collectively synchronize .... actions so that the data gets added together in a single batch.

val addDataMemoryActions = ArrayBuffer[AddDataMemory[_]]()
while (actionIterator.hasNext && actionIterator.head.isInstanceOf[AddDataMemory[_]]) {
addDataMemoryActions.append(actionIterator.next().asInstanceOf[AddDataMemory[_]])
}
if (addDataMemoryActions.nonEmpty) {
val synchronizeAll = addDataMemoryActions
Copy link
Contributor

@tdas tdas Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some magic-ish code. Can you add a bit more comments on how this compose thing works?

.map(t => t.source.synchronized[Unit] _)
.reduce(_.compose(_))
synchronizeAll {
addDataMemoryActions.foreach(handleAction)
}
} else {
handleAction(actionIterator.next())
}
}
def handleAction: StreamAction => Unit = { action =>
logInfo(s"Processing test stream action: $action")
action match {
case StartStream(trigger, triggerClock, additionalConfs, checkpointLocation) =>
Expand Down