Skip to content

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

a followup of #21100

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

Hi @liutang123 , hopefully you know how to write unit test for type coercion now and do it yourself next time :)

also cc @gatorsmile

@HyukjinKwon
Copy link
Member

not a big deal but title ..

@cloud-fan cloud-fan changed the title [[SPARK-24012][SQL]][TEST][followup] add unit test [SPARK-24012][SQL][TEST][followup] add unit test Apr 25, 2018
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Apr 25, 2018

Test build #89842 has finished for PR 21154 at commit f1a0f4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asfgit asfgit closed this in ac4ca7c Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants