[SPARK-24109] Remove class SnappyOutputStreamWrapper #21176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2018 11:40
…r-SnappyOutputStreamWrapper
|
Can one of the admins verify this patch? |
|
Have you checked the @srowen 's comment? #18949 (comment) |
|
@maropu Ok. It sounds reasonable to me |
asfgit
pushed a commit
that referenced
this pull request
Oct 11, 2018
## What changes were proposed in this pull request? Remove SnappyOutputStreamWrapper and other workaround now that new Snappy fixes these. See also #21176 and comments it links to. ## How was this patch tested? Existing tests Closes #22691 from srowen/SPARK-24109. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Remove SnappyOutputStreamWrapper and other workaround now that new Snappy fixes these. See also apache#21176 and comments it links to. ## How was this patch tested? Existing tests Closes apache#22691 from srowen/SPARK-24109. Authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-24109?jql=text%20~%20%22SnappyOutputStreamWrapper%22
Wrapper over
SnappyOutputStreamwhich guards against write-after-close and double-closeissues. See SPARK-7660 for more details.
This wrapping can be removed if we upgrade to a version
of snappy-java that contains the fix for xerial/snappy-java#107.
snappy-java:1.1.2+ fixed the bug