[SPARK-23325][WIP] Test parquet returning internal row #21237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow-up to #21118. |
|
Test build #90211 has finished for PR 21237 at commit
|
rdblue
force-pushed
the
test-parquet-returning-internal-row
branch
from
ab8bf23 to
669f492
Compare
|
Test build #90228 has finished for PR 21237 at commit
|
|
This is no longer needed. #21118 fixes the copy problem by always inserting a projection that copies, but delaying until after filters are run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This updates
ParquetFileFormatto returnInternalRowinstead ofUnsafeRowto get a rough assessment of how many code paths depend on interfaces that returnInternalRowactually returningUnsafeRow.How was this patch tested?
Existing tests.