[SPARK-24583][SQL] Wrong schema type in InsertIntoDataSourceCommand #21585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #92046 has finished for PR 21585 at commit
|
|
retest this please |
|
Test build #92047 has finished for PR 21585 at commit
|
|
@gatorsmile @cloud-fan Could you please review this PR? |
cloud-fan
reviewed
Jun 19, 2018
|
|
||
| class SimpleInsertSource extends SchemaRelationProvider { | ||
| override def createRelation( | ||
| sqlContext: SQLContext, |
cloud-fan
reviewed
Jun 19, 2018
| // Apply the schema of the existing table to the new data. | ||
| val df = sparkSession.internalCreateDataFrame(data.queryExecution.toRdd, logicalRelation.schema) | ||
| relation.insert(df, overwrite) | ||
| // Data should have been casted to the schema of the insert relation. |
There was a problem hiding this comment.
it's better to mention which rule did it
cloud-fan
reviewed
Jun 19, 2018
| compressed = false, | ||
| properties = Map.empty), | ||
| schema = schema, | ||
| provider = Some("org.apache.spark.sql.sources.SimpleInsertSource")) |
There was a problem hiding this comment.
use classOf[SimpleInsertSource].getName instead of hardcoding
|
thanks, LGTM |
|
Done with the changes. Thanks a lot, @cloud-fan ! |
|
Test build #92093 has finished for PR 21585 at commit
|
|
retest this please |
|
Test build #92092 has finished for PR 21585 at commit
|
|
Test build #92091 has finished for PR 21585 at commit
|
|
Test build #92095 has finished for PR 21585 at commit
|
|
Thanks! Merged to master/2.3 |
asfgit
pushed a commit
that referenced
this pull request
Jun 19, 2018
## What changes were proposed in this pull request? Change insert input schema type: "insertRelationType" -> "insertRelationType.asNullable", in order to avoid nullable being overridden. ## How was this patch tested? Added one test in InsertSuite. Author: Maryann Xue <[email protected]> Closes #21585 from maryannxue/spark-24583. (cherry picked from commit bc0498d) Signed-off-by: Xiao Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change insert input schema type: "insertRelationType" -> "insertRelationType.asNullable", in order to avoid nullable being overridden.
How was this patch tested?
Added one test in InsertSuite.