[SPARK-24537][R]Add array_remove / array_zip / map_from_arrays / array_distinct #21645
Conversation
|
Test build #92351 has finished for PR 21645 at commit
|
|
@HyukjinKwon @felixcheung |
R/pkg/R/functions.R
Outdated
| function(x, ...) { | ||
| jcols <- lapply(list(x, ...), function(x) { | ||
| stopifnot(class(x) == "Column") | ||
| x@jc |
There was a problem hiding this comment.
nit: probably clearer to name the x in function(x) as something else
| #' @note arrays_zip since 2.4.0 | ||
| setMethod("arrays_zip", | ||
| signature(x = "Column"), | ||
| function(x, ...) { |
There was a problem hiding this comment.
should add in doc that ... are Column for this function
https://github.com/huaxingao/spark/blob/87100ec766acf647e91ab14450f1c33c0f929d52/R/pkg/R/functions.R#L198
| #' @aliases array_remove array_remove,Column-method | ||
| #' @note array_remove since 2.4.0 | ||
| setMethod("array_remove", | ||
| signature(x = "Column", value = "ANY"), |
There was a problem hiding this comment.
should add in doc that for this function, value is ...?
https://github.com/huaxingao/spark/blob/87100ec766acf647e91ab14450f1c33c0f929d52/R/pkg/R/functions.R#L193
There was a problem hiding this comment.
Thanks for your review. I will add in doc.
|
Test build #92891 has finished for PR 21645 at commit
|
|
Merged to master. |
|
Thanks! @HyukjinKwon @felixcheung |
4 participants
What changes were proposed in this pull request?
Add array_remove / array_zip / map_from_arrays / array_distinct functions in SparkR.
How was this patch tested?
Add tests in test_sparkSQL.R