Skip to content

Conversation

@LantaoJin
Copy link
Contributor

…gen issue

What changes were proposed in this pull request?

"distribute by" on multiple columns may lead to codegen issue

How was this patch tested?

manual test

@LantaoJin
Copy link
Contributor Author

@cloud-fan @jerryshao

@jerryshao
Copy link
Contributor

ok to test.

@SparkQA
Copy link

SparkQA commented Aug 10, 2018

Test build #94547 has finished for PR 22067 at commit 9e6941c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LantaoJin
Copy link
Contributor Author

ok to test.

@LantaoJin
Copy link
Contributor Author

@jerryshao Could you help to trigger test build please?

@LantaoJin
Copy link
Contributor Author

Add unit test with a rand() column in 'distribute by'

@SparkQA
Copy link

SparkQA commented Aug 10, 2018

Test build #94556 has finished for PR 22067 at commit 0a6bccc.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Aug 10, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Aug 10, 2018

Test build #94562 has finished for PR 22067 at commit b799e92.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 10, 2018

Test build #94568 has finished for PR 22067 at commit b799e92.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LantaoJin
Copy link
Contributor Author

�Seems #22066 has changed the implementation with a similar approach. I will close this one.

@LantaoJin LantaoJin closed this Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants