Skip to content

Conversation

@dbtsai
Copy link
Member

@dbtsai dbtsai commented Sep 24, 2018

What changes were proposed in this pull request?

Support Parquet predicate pushdown in nested fields

How was this patch tested?

Existing tests and new tests are added.

@SparkQA
Copy link

SparkQA commented Sep 24, 2018

Test build #96506 has started for PR 22535 at commit c95706f.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be a good performance improvement for Spark 2.5.0.

@viirya
Copy link
Member

viirya commented Sep 24, 2018

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 25, 2018

Test build #96528 has finished for PR 22535 at commit c95706f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Hi, @dbtsai . Could you fix the UT failure?

[info] ParquetFilterSuite:
...
[info] - SPARK-12218 Converting conjunctions into Parquet filter predicates *** FAILED *** (19 milliseconds)
[info]   Expected None, but got Some(lt(a, 10)) (ParquetFilterSuite.scala:802)

@dbtsai
Copy link
Member Author

dbtsai commented Sep 27, 2018

I'm breaking this PRs into three smaller PR. I'll fix the tests in those smaller PRs. Thanks.

@SparkQA
Copy link

SparkQA commented Dec 4, 2018

Test build #99673 has finished for PR 22535 at commit c95706f.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 14, 2019

Test build #101203 has finished for PR 22535 at commit 49f19a9.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 14, 2019

Test build #101204 has finished for PR 22535 at commit eb400ed.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@aniket486
Copy link

@dbtsai are you still working on this?

@SparkQA
Copy link

SparkQA commented Dec 10, 2019

Test build #115067 has finished for PR 22535 at commit eb400ed.

  • This patch fails build dependency tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member Author

dbtsai commented Feb 28, 2020

Going to close this in favor of new PR, #27728

@dbtsai dbtsai closed this Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants