[SPARK-25534][SQL] Make SQLHelper trait
#22548
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this PR, @cloud-fan , @gatorsmile , and @wangyum ? |
dongjoon-hyun
commented
Sep 25, 2018
| * mandating a FunSuite. | ||
| */ | ||
| trait PlanTestBase extends PredicateHelper { self: Suite => | ||
| trait PlanTestBase extends PredicateHelper with SupportWithSQLConf { self: Suite => |
Member
Author
There was a problem hiding this comment.
I put SupportWithSQLConf.scala in the same package with PlanTest. If needed, we can move this to another better place.
Contributor
|
We have duplicated |
Member
Author
|
+1, Sure, @cloud-fan ! |
Member
Author
|
It turns out that def withTempTable(tableNames: String*)(f: => Unit): Unit = {
try f finally tableNames.foreach(spark.catalog.dropTempView)
}Since it requires function signature changes, shall we postpone |
Contributor
|
sure |
dongjoon-hyun
changed the title
SupportWithSQLConf traitSQLHelper trait
cloud-fan
approved these changes
Sep 26, 2018
|
Test build #96579 has finished for PR 22548 at commit
|
Member
Author
|
Thank you, @HyukjinKwon and @cloud-fan ! I'll merge this to the master. It's still running. |
|
Test build #96586 has finished for PR 22548 at commit
|
Member
Author
|
It passed. Merged to |
daspalrahul
pushed a commit
to daspalrahul/spark
that referenced
this pull request
Sep 29, 2018
## What changes were proposed in this pull request?
Currently, Spark has 7 `withTempPath` and 6 `withSQLConf` functions. This PR aims to remove duplicated and inconsistent code and reduce them to the following meaningful implementations.
**withTempPath**
- `SQLHelper.withTempPath`: The one which was used in `SQLTestUtils`.
**withSQLConf**
- `SQLHelper.withSQLConf`: The one which was used in `PlanTest`.
- `ExecutorSideSQLConfSuite.withSQLConf`: The one which doesn't throw `AnalysisException` on StaticConf changes.
- `SQLTestUtils.withSQLConf`: The one which overrides intentionally to change the active session.
```scala
protected override def withSQLConf(pairs: (String, String)*)(f: => Unit): Unit = {
SparkSession.setActiveSession(spark)
super.withSQLConf(pairs: _*)(f)
}
```
## How was this patch tested?
Pass the Jenkins with the existing tests.
Closes apache#22548 from dongjoon-hyun/SPARK-25534.
Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, Spark has 7
withTempPathand 6withSQLConffunctions. This PR aims to remove duplicated and inconsistent code and reduce them to the following meaningful implementations.withTempPath
SQLHelper.withTempPath: The one which was used inSQLTestUtils.withSQLConf
SQLHelper.withSQLConf: The one which was used inPlanTest.ExecutorSideSQLConfSuite.withSQLConf: The one which doesn't throwAnalysisExceptionon StaticConf changes.SQLTestUtils.withSQLConf: The one which overrides intentionally to change the active session.How was this patch tested?
Pass the Jenkins with the existing tests.