[SPARK-25702][SQL] Push down filters with Not operator in Parquet
#22687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't such predicates be simplified at |
HyukjinKwon
reviewed
Oct 10, 2018
| createFilterHelper(nameToParquetField, | ||
| sources.And(sources.Not(lhs), sources.Not(rhs)), canPartialPushDownConjuncts = true) | ||
|
|
||
| case sources.Not(sources.Not(pred)) if canPartialPushDownConjuncts => |
There was a problem hiding this comment.
hm, is this actually reachable?
|
@viirya @HyukjinKwon I did the code changes and then I found the condition is not reachable, as I have stated in PR description. Just feel that it won't hurt to have such handling in data source module, the changes in code is short. I am OK to close this one. |
|
I prefer not to add code that will not run. Let's see others options too. |
|
It's OK. Close this one. |
|
Test build #97193 has finished for PR 22687 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, in ParquetFilters, predicates inside
Notoperator are considered as unable to perform partial push down.However, the following cases is still possible for push down:
Not(Or(left, right))can be conversed asAnd(Not(left), Not(right))Not(Not(pred))can be conversed aspredBoth cases should be quite trivial, since the
Notoperator should be pushed down by optimization ruleBooleanSimplificationalready.But I think it should be good to handle such cases in Parquet data source module as well.
How was this patch tested?
New unit test.