[SPARK-25763][SQL][PYSPARK][TEST] Use more @contextmanager to ensure clean-up each test.
#22762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #97524 has finished for PR 22762 at commit
|
Member
Author
|
Jenkins, retest this please. |
Member
Author
|
cc @HyukjinKwon |
|
Test build #97526 has finished for PR 22762 at commit
|
Member
|
I like it! |
HyukjinKwon
approved these changes
Oct 18, 2018
python/pyspark/sql/tests.py
Outdated
| """ | ||
| assert hasattr(self, "spark"), "it should have 'spark' attribute, having a spark session." | ||
|
|
||
| if len(databases) == 1 and isinstance(databases[0], (list, set)): |
Member
There was a problem hiding this comment.
hey @ueshin, how about we just allow database(a, b, ...) case only for now?
Member
There was a problem hiding this comment.
like .. an assert by this condition all(map(lambda d: isinstance(d, str), databases)) should be good enough.
|
Test build #97531 has finished for PR 22762 at commit
|
|
Test build #97536 has finished for PR 22762 at commit
|
|
Test build #97537 has finished for PR 22762 at commit
|
Member
|
Merged to master. |
HyukjinKwon
reviewed
Oct 18, 2018
| def table(self, *tables): | ||
| """ | ||
| A convenient context manager to test with some specific tables. This drops the given tables | ||
| if exist when it exits. |
Member
There was a problem hiding this comment.
wait .. not a big deal but typo: if exist when it exits..
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…e clean-up each test. ## What changes were proposed in this pull request? Currently each test in `SQLTest` in PySpark is not cleaned properly. We should introduce and use more `contextmanager` to be convenient to clean up the context properly. ## How was this patch tested? Modified tests. Closes apache#22762 from ueshin/issues/SPARK-25763/cleanup_sqltests. Authored-by: Takuya UESHIN <[email protected]> Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently each test in
SQLTestin PySpark is not cleaned properly.We should introduce and use more
@contextmanagerto be convenient to clean up the context properly.How was this patch tested?
Modified tests.