[SPARK-26226][SQL] Update query tracker to report timeline for phases #23183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #99479 has finished for PR 23183 at commit
|
|
Test build #99481 has finished for PR 23183 at commit
|
|
Test build #99487 has finished for PR 23183 at commit
|
|
Test build #99500 has finished for PR 23183 at commit
|
|
retest this please |
|
Test build #99503 has finished for PR 23183 at commit
|
|
Test build #99516 has finished for PR 23183 at commit
|
gatorsmile
reviewed
Nov 30, 2018
| def durationMs: Long = endTimeMs - startTimeMs | ||
|
|
||
| override def toString: String = { | ||
| s"PhaseSummary($startTimeMs, $endTimeMs)" |
There was a problem hiding this comment.
Also include the duration in toString?
There was a problem hiding this comment.
so for actual debugging this is not needed right?
|
LGTM Thanks! Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This patch changes the query plan tracker added earlier to report phase timeline, rather than just a duration for each phase. This way, we can easily find time that's unaccounted for. ## How was this patch tested? Updated test cases to reflect that. Closes apache#23183 from rxin/SPARK-26226. Authored-by: Reynold Xin <[email protected]> Signed-off-by: gatorsmile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch changes the query plan tracker added earlier to report phase timeline, rather than just a duration for each phase. This way, we can easily find time that's unaccounted for.
How was this patch tested?
Updated test cases to reflect that.