Skip to content

Conversation

@xuanyuanking
Copy link
Member

What changes were proposed in this pull request?

Backport #23277 to branch 2.4 without the metrics renaming.

How was this patch tested?

New test case in SQLMetricsSuite.

@SparkQA
Copy link

SparkQA commented Dec 11, 2018

Test build #99976 has finished for PR 23287 at commit 368c7b5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to branch-2.4

dongjoon-hyun pushed a commit that referenced this pull request Dec 11, 2018
…rics update

## What changes were proposed in this pull request?

Backport #23277 to branch 2.4 without the metrics renaming.

## How was this patch tested?

New test case in `SQLMetricsSuite`.

Closes #23287 from xuanyuanking/SPARK-26327-2.4.

Authored-by: Yuanjian Li <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
@dongjoon-hyun
Copy link
Member

@dongjoon-hyun
Copy link
Member

I triggered re-sync at https://selfserve.apache.org/ and am waiting.

We've triggered a re-sync for spark!

@dongjoon-hyun
Copy link
Member

Hi, @srowen . If Apache SelfServe doesn't work, should we file an INFRA JIRA issue or do we need to wait for the next commit on branch-2.4?

@srowen
Copy link
Member

srowen commented Dec 11, 2018

I'd say either just wait today, or push a dummy commit to try again, and if those don't work, yes file an INFRA ticket. Maybe somehow the other branches aren't synced but I imagine they are supposed to.

@dongjoon-hyun
Copy link
Member

Thank you. Yep. I'll wait and monitor today and proceed like that.

@xuanyuanking
Copy link
Member Author

Thanks Sean and Dongjoon, just ping me if a dummy commit is needed.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 12, 2018

Thanks. @xuanyuanking . This landed on branch-2.4 correctly. So, I close this.

@xuanyuanking
Copy link
Member Author

Thanks Dongjoon.

@xuanyuanking xuanyuanking deleted the SPARK-26327-2.4 branch December 12, 2018 16:04
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
…rics update

## What changes were proposed in this pull request?

Backport apache#23277 to branch 2.4 without the metrics renaming.

## How was this patch tested?

New test case in `SQLMetricsSuite`.

Closes apache#23287 from xuanyuanking/SPARK-26327-2.4.

Authored-by: Yuanjian Li <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
…rics update

## What changes were proposed in this pull request?

Backport apache#23277 to branch 2.4 without the metrics renaming.

## How was this patch tested?

New test case in `SQLMetricsSuite`.

Closes apache#23287 from xuanyuanking/SPARK-26327-2.4.

Authored-by: Yuanjian Li <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants