[SPARK-26316][BRANCH-2.4] Revert hash join metrics in spark 21052 that causes performance degradation #23318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
|
Can you fix the PR title to |
JkSelf
changed the title
JkSelf
changed the title
|
@HyukjinKwon ok. Fixed. |
|
Test build #100128 has finished for PR 23318 at commit
|
|
Test build #100134 has finished for PR 23318 at commit
|
|
Retest this please. |
|
Test build #100166 has finished for PR 23318 at commit
|
|
cc @viirya |
dongjoon-hyun
approved these changes
Dec 17, 2018
asfgit
pushed a commit
that referenced
this pull request
Dec 17, 2018
…at causes performance degradation ## What changes were proposed in this pull request? revert spark 21052 in spark 2.4 because of the discussion in [PR23269](#23269) ## How was this patch tested? N/A Closes #23318 from JkSelf/branch-2.4-revert21052. Authored-by: jiake <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Thank you, @JkSelf . |
|
Late LGTM. Thanks @dongjoon-hyun for pinging me. @JkSelf As this was merged, you can close it now. |
|
Thank you, @viirya . BTW, I forgot to close this. After Gitbox transition, the committers are able to close. |
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
…at causes performance degradation ## What changes were proposed in this pull request? revert spark 21052 in spark 2.4 because of the discussion in [PR23269](apache#23269) ## How was this patch tested? N/A Closes apache#23318 from JkSelf/branch-2.4-revert21052. Authored-by: jiake <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
…at causes performance degradation ## What changes were proposed in this pull request? revert spark 21052 in spark 2.4 because of the discussion in [PR23269](apache#23269) ## How was this patch tested? N/A Closes apache#23318 from JkSelf/branch-2.4-revert21052. Authored-by: jiake <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
revert spark 21052 in spark 2.4 because of the discussion in PR23269
How was this patch tested?
N/A