Skip to content

Conversation

@maropu
Copy link
Member

@maropu maropu commented Feb 17, 2019

What changes were proposed in this pull request?

This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

How was this patch tested?

Pass the Jenkins.

@SparkQA
Copy link

SparkQA commented Feb 18, 2019

Test build #102437 has finished for PR 23817 at commit ff45948.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Feb 18, 2019

@srowen @dongjoon-hyun If no problem, could you merge this?

HyukjinKwon pushed a commit that referenced this pull request Feb 18, 2019
….1.x in HiveExternalCatalogVersionsSuite

## What changes were proposed in this pull request?
This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

## How was this patch tested?
Pass the Jenkins.

Closes #23817 from maropu/SPARK-26607-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit e2b8cc6)
Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon pushed a commit that referenced this pull request Feb 18, 2019
….1.x in HiveExternalCatalogVersionsSuite

## What changes were proposed in this pull request?
This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

## How was this patch tested?
Pass the Jenkins.

Closes #23817 from maropu/SPARK-26607-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit e2b8cc6)
Signed-off-by: Hyukjin Kwon <[email protected]>
@HyukjinKwon
Copy link
Member

Merged to master, branch-2.4, and branch-2.3.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
….1.x in HiveExternalCatalogVersionsSuite

## What changes were proposed in this pull request?
This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

## How was this patch tested?
Pass the Jenkins.

Closes apache#23817 from maropu/SPARK-26607-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, late LGTM, too.

@srowen
Copy link
Member

srowen commented Feb 19, 2019

Oh @HyukjinKwon would branch-2.4 and branch-2.3 still potentially be testing vs older Spark versions? I had thought this was for master.

@HyukjinKwon
Copy link
Member

Hm, I thought we disabled tests for those EOL releases by:

bb97459#diff-451a407d92e675bc747901202e46472a

b6c4649#diff-451a407d92e675bc747901202e46472a

@srowen
Copy link
Member

srowen commented Feb 19, 2019

I guess that's fine; if a release is EOL now but wasn't when the branch was started, still reasonable to stop testing it in the branch.

@HyukjinKwon
Copy link
Member

I see. Thanks, @srowen. BTW, Please feel free to revert this in branch-2.3 and branch-2.4 @srowen if you see any other concern later. I don't mind at all.

kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
….1.x in HiveExternalCatalogVersionsSuite

## What changes were proposed in this pull request?
This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

## How was this patch tested?
Pass the Jenkins.

Closes apache#23817 from maropu/SPARK-26607-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit e2b8cc6)
Signed-off-by: Hyukjin Kwon <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
….1.x in HiveExternalCatalogVersionsSuite

## What changes were proposed in this pull request?
This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

## How was this patch tested?
Pass the Jenkins.

Closes apache#23817 from maropu/SPARK-26607-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit e2b8cc6)
Signed-off-by: Hyukjin Kwon <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
….1.x in HiveExternalCatalogVersionsSuite

## What changes were proposed in this pull request?
This pr just removed workaround for 2.2.0 and 2.1.x in HiveExternalCatalogVersionsSuite.

## How was this patch tested?
Pass the Jenkins.

Closes apache#23817 from maropu/SPARK-26607-FOLLOWUP.

Authored-by: Takeshi Yamamuro <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
(cherry picked from commit e2b8cc6)
Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants