[SPARK-27102][R][PYTHON][CORE] Remove the references to Python's Scala codes in R's Scala codes #24023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
commented
Mar 8, 2019
Member
Author
There was a problem hiding this comment.
All moved codes are as are, except that I made this private.
Member
Author
|
cc @vanzin, @felixcheung, @squito |
This comment has been minimized.
This comment has been minimized.
|
Test build #103196 has finished for PR 24023 at commit
|
Contributor
|
retest this please |
|
Test build #103198 has finished for PR 24023 at commit
|
squito
approved these changes
Mar 8, 2019
Contributor
squito
left a comment
squito
left a comment
There was a problem hiding this comment.
Just want to double-check I understand -- you're not trying to change any behavior, just don't want "python" to appear in stack traces from R?
a couple very minor style things, but lgtm otherwise.
core/src/main/scala/org/apache/spark/security/SocketAuthServer.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/security/SocketAuthHelper.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
@squito, Yup. That's the main reason and I tried to not change behaviour, yes. Actually I received some comments that's a bit odd R's Scala codes refers Python's Scala codes from @vanzin and @felixcheung as well. |
|
Test build #103241 has finished for PR 24023 at commit
|
|
Test build #103243 has finished for PR 24023 at commit
|
srowen
approved these changes
Mar 9, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looks good if this is just a refactoring
viirya
approved these changes
Mar 9, 2019
Member
|
LGTM |
Member
Author
|
Merged to master. Thanks, guys. |
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 4, 2020
…a codes in R's Scala codes ## What changes were proposed in this pull request? Currently, R's Scala codes happened to refer Python's Scala codes for code deduplications. It's a bit odd. For instance, when we face an exception from R, it shows python related code path, which makes confusing to debug. It should rather have one code base and R's and Python's should share. This PR proposes: 1. Make a `SocketAuthServer` and move `PythonServer` so that `PythonRDD` and `RRDD` can share it. 2. Move `readRDDFromFile` and `readRDDFromInputStream` into `JavaRDD`. 3. Reuse `RAuthHelper` and remove `RSocketAuthHelper` in `RRDD`. 4. Rename `getEncryptionEnabled` to `isEncryptionEnabled` while I am here. So, now, the places below: - `sql/core/src/main/scala/org/apache/spark/sql/api/r` - `core/src/main/scala/org/apache/spark/api/r` - `mllib/src/main/scala/org/apache/spark/ml/r` don't refer Python's Scala codes. ## How was this patch tested? Existing tests should cover this. Closes apache#24023 from HyukjinKwon/SPARK-27102. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 5, 2020
…a codes in R's Scala codes ## What changes were proposed in this pull request? Currently, R's Scala codes happened to refer Python's Scala codes for code deduplications. It's a bit odd. For instance, when we face an exception from R, it shows python related code path, which makes confusing to debug. It should rather have one code base and R's and Python's should share. This PR proposes: 1. Make a `SocketAuthServer` and move `PythonServer` so that `PythonRDD` and `RRDD` can share it. 2. Move `readRDDFromFile` and `readRDDFromInputStream` into `JavaRDD`. 3. Reuse `RAuthHelper` and remove `RSocketAuthHelper` in `RRDD`. 4. Rename `getEncryptionEnabled` to `isEncryptionEnabled` while I am here. So, now, the places below: - `sql/core/src/main/scala/org/apache/spark/sql/api/r` - `core/src/main/scala/org/apache/spark/api/r` - `mllib/src/main/scala/org/apache/spark/ml/r` don't refer Python's Scala codes. ## How was this patch tested? Existing tests should cover this. Closes apache#24023 from HyukjinKwon/SPARK-27102. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, R's Scala codes happened to refer Python's Scala codes for code deduplications. It's a bit odd. For instance, when we face an exception from R, it shows python related code path, which makes confusing to debug. It should rather have one code base and R's and Python's should share.
This PR proposes:
SocketAuthServerand movePythonServerso thatPythonRDDandRRDDcan share it.readRDDFromFileandreadRDDFromInputStreamintoJavaRDD.RAuthHelperand removeRSocketAuthHelperinRRDD.getEncryptionEnabledtoisEncryptionEnabledwhile I am here.So, now, the places below:
sql/core/src/main/scala/org/apache/spark/sql/api/rcore/src/main/scala/org/apache/spark/api/rmllib/src/main/scala/org/apache/spark/ml/rdon't refer Python's Scala codes.
How was this patch tested?
Existing tests should cover this.