-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-3571] Spark standalone cluster mode doesn't work. #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
QA tests have started for PR 2436 at commit
|
|
Oops, good catch... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this result in an infinite loop if no workers are available? curPos is never equal to aliveWorkerNum
|
QA tests have started for PR 2436 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned before, this is not correct. curPos != stopPos will always be true since curPos is always mod aliveWorkerNum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. I'll modify.
|
QA tests have finished for PR 2436 at commit
|
|
QA tests have started for PR 2436 at commit
|
|
QA tests have started for PR 2436 at commit
|
|
QA tests have finished for PR 2436 at commit
|
|
QA tests have finished for PR 2436 at commit
|
|
retest this please. |
|
QA tests have finished for PR 2436 at commit
|
|
Ok, LGTM... I tested this locally. Merging into master. |
I think, this issue is caused by #1106