Skip to content

Conversation

@gengliangwang
Copy link
Member

What changes were proposed in this pull request?

The method QueryPlan.sameResult is used for comparing logical plans in order to:

  1. cache data in CacheManager
  2. uncache data in CacheManager
  3. Reuse subqueries
  4. etc...

Currently the method sameReuslt always return false for BatchScanExec. We should fix it by implementing doCanonicalize for the node.

How was this patch tested?

Unit test

@gengliangwang
Copy link
Member Author

@cloud-fan

@SparkQA
Copy link

SparkQA commented Apr 26, 2019

Test build #104950 has finished for PR 24475 at commit 8a7cc19.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 26, 2019

Test build #104945 has finished for PR 24475 at commit 0130f07.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 07d07fe Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants