Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Aug 26, 2019

What changes were proposed in this pull request?

Test spark.sql.redaction.options.regex with and without default values.

Why are the changes needed?

Normally, we do not rely on the default value of spark.sql.redaction.options.regex.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Jenkins

@SparkQA
Copy link

SparkQA commented Aug 26, 2019

Test build #109712 has finished for PR 25579 at commit d45ccb1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@wangyum wangyum deleted the SPARK-28642-f1 branch August 26, 2019 06:23
@dongjoon-hyun
Copy link
Member

Thank you, @wangyum , @HyukjinKwon , @gatorsmile .
Since RC2 failed, I tested this manually and landed this to branch-2.4 for RC3.

dongjoon-hyun pushed a commit that referenced this pull request Aug 27, 2019
…regex with and without default values

### What changes were proposed in this pull request?

Test `spark.sql.redaction.options.regex` with and without  default values.

### Why are the changes needed?

Normally, we do not rely on the default value of `spark.sql.redaction.options.regex`.

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
N/A

Closes #25579 from wangyum/SPARK-28642-f1.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Xiao Li <[email protected]>
(cherry picked from commit c353a84)
Signed-off-by: Dongjoon Hyun <[email protected]>
rluta pushed a commit to rluta/spark that referenced this pull request Sep 17, 2019
…regex with and without default values

### What changes were proposed in this pull request?

Test `spark.sql.redaction.options.regex` with and without  default values.

### Why are the changes needed?

Normally, we do not rely on the default value of `spark.sql.redaction.options.regex`.

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
N/A

Closes apache#25579 from wangyum/SPARK-28642-f1.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Xiao Li <[email protected]>
(cherry picked from commit c353a84)
Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Sep 26, 2019
…regex with and without default values

### What changes were proposed in this pull request?

Test `spark.sql.redaction.options.regex` with and without  default values.

### Why are the changes needed?

Normally, we do not rely on the default value of `spark.sql.redaction.options.regex`.

### Does this PR introduce any user-facing change?
No

### How was this patch tested?
N/A

Closes apache#25579 from wangyum/SPARK-28642-f1.

Authored-by: Yuming Wang <[email protected]>
Signed-off-by: Xiao Li <[email protected]>
(cherry picked from commit c353a84)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants