[SPARK-3708][SQL] Backticks aren't handled correctly is aliases #2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
Test FAILed. |
|
@marmbrus I am not sure why it is failed. The error shows git could not fetch the code and timed out. Do I have to do something here.? |
|
Git hub can be surprisingly flakey. Feel free to ping me when this happens and I'll restart the tests. |
|
QA tests have started for PR 2594 at commit
|
|
QA tests have finished for PR 2594 at commit
|
|
Nice clean fix :) Thanks for doing this! Merged to master. |
marmbrus
pushed a commit
to marmbrus/spark
that referenced
this pull request
Nov 11, 2014
The below query gives error
sql("SELECT k FROM (SELECT \`key\` AS \`k\` FROM src) a")
It gives error because the aliases are not cleaned so it could not be resolved in further processing.
Author: ravipesala <[email protected]>
Closes apache#2594 from ravipesala/SPARK-3708 and squashes the following commits:
d55db54 [ravipesala] Fixed SPARK-3708 (Backticks aren't handled correctly is aliases)
Conflicts:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below query gives error
sql("SELECT k FROM (SELECT
keyASkFROM src) a")It gives error because the aliases are not cleaned so it could not be resolved in further processing.