[SPARK-29470][BUILD] Update plugins to latest versions #26117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
Oct 14, 2019
| <module name="LineLength"> | ||
| <property name="max" value="100"/> | ||
| <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/> | ||
| </module> |
There was a problem hiding this comment.
This is banned at 8.24. We need to move out from TreeWalker.
dongjoon-hyun
commented
Oct 14, 2019
|
|
||
| # SPARK-9183: Settings to avoid annoying messages when looking up nonexistent UDFs in SparkSQL with Hive support | ||
| # SPARK-9183: Settings to avoid annoying messages when looking up nonexistent UDFs | ||
| # in SparkSQL with Hive support |
There was a problem hiding this comment.
$ dev/lint-java
OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=384m; support was removed in 8.0
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks failed at following occurrences:
[ERROR] src/main/resources/org/apache/spark/log4j-defaults.properties:[36] (sizes) LineLength: Line is longer than 100 characters (found 112).
|
Test build #112071 has finished for PR 26117 at commit
|
|
Test build #112074 has finished for PR 26117 at commit
|
|
Hi, @viirya . Could you review this, please? |
viirya
reviewed
Oct 15, 2019
Comment on lines
20
to
+21
| // sbt-checkstyle-plugin uses an old version of checkstyle. Match it to Maven's. | ||
| libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "8.23" | ||
| libraryDependencies += "com.puppycrawl.tools" % "checkstyle" % "8.25" |
There was a problem hiding this comment.
Why it is an old version? Looks like it is very new version?
https://mvnrepository.com/artifact/com.puppycrawl.tools/checkstyle
There was a problem hiding this comment.
The description sbt-checkstyle-plugin uses an old version means that sbt-checkstyle-plugin depends on the old version and we need to override it here. :)
viirya
approved these changes
Oct 15, 2019
|
Thank you so much for review and approval, @viirya ! |
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 4, 2020
This PR updates plugins to latest versions. This brings bug fixes like the following. - https://issues.apache.org/jira/projects/MCOMPILER/versions/12343484 (maven-compiler-plugin) - https://issues.apache.org/jira/projects/MJAVADOC/versions/12345060 (maven-javadoc-plugin) - https://issues.apache.org/jira/projects/MCHECKSTYLE/versions/12342397 (maven-checkstyle-plugin) - https://checkstyle.sourceforge.io/releasenotes.html#Release_8.25 (checkstyle) - https://checkstyle.sourceforge.io/releasenotes.html#Release_8.24 (checkstyle) No. Pass the Jenkins building and testing with the existing code. Closes apache#26117 from dongjoon-hyun/SPARK-29470. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 5, 2020
This PR updates plugins to latest versions. This brings bug fixes like the following. - https://issues.apache.org/jira/projects/MCOMPILER/versions/12343484 (maven-compiler-plugin) - https://issues.apache.org/jira/projects/MJAVADOC/versions/12345060 (maven-javadoc-plugin) - https://issues.apache.org/jira/projects/MCHECKSTYLE/versions/12342397 (maven-checkstyle-plugin) - https://checkstyle.sourceforge.io/releasenotes.html#Release_8.25 (checkstyle) - https://checkstyle.sourceforge.io/releasenotes.html#Release_8.24 (checkstyle) No. Pass the Jenkins building and testing with the existing code. Closes apache#26117 from dongjoon-hyun/SPARK-29470. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates plugins to latest versions.
Why are the changes needed?
This brings bug fixes like the following.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the Jenkins building and testing with the existing code.