[SPARK-29796][SQL][TESTS] HiveExternalCatalogVersionsSuite should ignore preview release
#26428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hi, @cloud-fan and @jiangxb1987 . |
dongjoon-hyun
changed the title
HiveExternalCatalogVersionsSuite should ignore preview releaseHiveExternalCatalogVersionsSuite should ignore preview release
jiangxb1987
approved these changes
Nov 7, 2019
Contributor
jiangxb1987
left a comment
jiangxb1987
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this @dongjoon-hyun !
Member
Author
|
Thank you, @jiangxb1987 . |
dongjoon-hyun
added a commit
that referenced
this pull request
Nov 7, 2019
…gnore preview release ### What changes were proposed in this pull request? This aims to exclude the `preview` release to recover `HiveExternalCatalogVersionsSuite`. Currently, new preview release breaks `branch-2.4` PRBuilder since yesterday. New release (especially `preview`) should not affect `branch-2.4`. - #26417 (Failed 4 times) ### Why are the changes needed? **BEFORE** ```scala scala> scala.io.Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString.split("\n").filter(_.contains("""<li><a href="spark-""")).map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) java.util.NoSuchElementException: None.get ``` **AFTER** ```scala scala> scala.io.Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString.split("\n").filter(_.contains("""<li><a href="spark-""")).filterNot(_.contains("preview")).map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1)) res5: Array[String] = Array(2.3.4, 2.4.4) ``` ### Does this PR introduce any user-facing change? No. ### How was this patch tested? This should pass the PRBuilder. Closes #26428 from dongjoon-hyun/SPARK-HiveExternalCatalogVersionsSuite. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit da848b1) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Nice, I was wondering why that was failing suddenly. |
|
Test build #113396 has finished for PR 26428 at commit
|
Member
Author
|
Thank you, @srowen and @HyukjinKwon . |
Member
|
Thanks for fixing it very quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This aims to exclude the
previewrelease to recoverHiveExternalCatalogVersionsSuite. Currently, new preview release breaksbranch-2.4PRBuilder since yesterday. New release (especiallypreview) should not affectbranch-2.4.Why are the changes needed?
BEFORE
AFTER
Does this PR introduce any user-facing change?
No.
How was this patch tested?
This should pass the PRBuilder.