[SPARK-30333][CORE][BUILD][BRANCH-2.4] Upgrade jackson-databind to 2.6.7.3 #26986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
srowen
reviewed
Dec 23, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
You might have to run dev/test-dependencies.sh --replace-manifest but looks OK otherwise
Member
|
ok to test |
HyukjinKwon
approved these changes
Dec 24, 2019
|
Test build #115673 has finished for PR 26986 at commit
|
maropu
changed the title
maropu
approved these changes
Dec 24, 2019
maropu
pushed a commit
that referenced
this pull request
Dec 24, 2019
### What changes were proposed in this pull request? Upgrade jackson-databind to 2.6.7.3 to following CVE CVE-2018-14718 - CVE-2018-14721 FasterXML/jackson-databind#2097 CVE-2018-19360, CVE-2018-19361, CVE-2018-19362 FasterXML/jackson-databind#2186 tag: https://github.com/FasterXML/jackson-databind/commits/jackson-databind-2.6.7.3 ### Why are the changes needed? CVE-2018-14718,CVE-2018-14719,CVE-2018-14720,CVE-2018-14721,CVE-2018-19360,CVE-2018-19361,CVE-2018-19362 ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UT Closes #26986 from sandeep-katta/jacksonUpgrade. Authored-by: sandeep katta <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>
Member
|
@sandeep-katta oh... Can you open another new pr for master? In this pr, the target is branch-2.4 and I couldn't cherry-pick it cleanly.. |
Contributor
Author
Master is using 2.10.0, so not required to merge this to master |
Member
|
ah... if so, can you add |
sandeep-katta
changed the title
Member
|
ok, Thanks! Merged to branch-2.4. |
Member
|
Hi, All. It seems that we missed |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 17, 2020
### What changes were proposed in this pull request? This PR aims to update `SparkBuild.scala` as a follow-up of [SPARK-30333 Upgrade jackson-databind to 2.6.7.3](#26986). ### Why are the changes needed? Since SPARK-29781, we override SBT Jackson dependency like Maven. ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Pass the Jenkins. Closes #27256 from dongjoon-hyun/SPARK-30333. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade jackson-databind to 2.6.7.3 to following CVE
CVE-2018-14718 - CVE-2018-14721
FasterXML/jackson-databind#2097
CVE-2018-19360, CVE-2018-19361, CVE-2018-19362
FasterXML/jackson-databind#2186
tag: https://github.com/FasterXML/jackson-databind/commits/jackson-databind-2.6.7.3
Why are the changes needed?
CVE-2018-14718,CVE-2018-14719,CVE-2018-14720,CVE-2018-14721,CVE-2018-19360,CVE-2018-19361,CVE-2018-19362
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT