Skip to content

[SPARK-30604][CORE] Fix a log message by including hostLocalBlockBytes to total bytes #27320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-30604][CORE] Fix a log message by including hostLocalBlockBytes to total bytes #27320

wants to merge 1 commit into from

Conversation

@Udbhav30
Copy link
Contributor

@Udbhav30 Udbhav30 commented Jan 22, 2020 •
edited
Loading

What changes were proposed in this pull request?

Add HostLocalBlock size in log total bytes

Why are the changes needed?

total size in log is wrong as hostlocal block size is missed

Does this PR introduce any user-facing change?

no

How was this patch tested?

Manually checking the log

@Udbhav30
Copy link
Contributor Author

Udbhav30 commented Jan 22, 2020 •
edited
Loading

Hi @dongjoon-hyun can you please review this

@Udbhav30 Udbhav30 requested a review from cloud-fan January 22, 2020 16:19
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30604 Add HostLocalBlock size in log total bytes] [SPARK-30604][CORE] Add HostLocalBlock size in log total bytes Jan 22, 2020
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020

Thank you for pinging me.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020

ok to test

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30604][CORE] Add HostLocalBlock size in log total bytes [SPARK-30604][CORE] Add hostLocalBlockBytes to total bytes in log Jan 22, 2020
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30604][CORE] Add hostLocalBlockBytes to total bytes in log [SPARK-30604][CORE] Fix a log message by including hostLocalBlockBytes to total bytes Jan 22, 2020
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020

@Udbhav30
BTW, why do you remove the required template? Although you cannot describe how to do, please add back and mentioned like Manually checking the log at least.

How was this patch tested?

@Udbhav30
Copy link
Contributor Author

Udbhav30 commented Jan 22, 2020

@Udbhav30
BTW, why do you remove the required template? Although you cannot describe how to do, please add back and mentioned like Manually checking the log at least.

How was this patch tested?

@dongjoon-hyun
Updated, thanks

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020

Thanks!

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020 •
edited
Loading

Since this seems to be caused by SPARK-27651, cc @attilapiros and @vanzin .

@SparkQA
Copy link

SparkQA commented Jan 22, 2020

Test build #117247 has finished for PR 27320 at commit 5331053.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020

Retest this please.

@SparkQA
Copy link

SparkQA commented Jan 22, 2020

Test build #117250 has finished for PR 27320 at commit 5331053.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 22, 2020

Merged to master.

@Udbhav30 Udbhav30 deleted the bug branch January 23, 2020 06:55
@Udbhav30 Udbhav30 restored the bug branch January 23, 2020 06:56
@Udbhav30 Udbhav30 deleted the bug branch January 23, 2020 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

@cloud-fan cloud-fan Awaiting requested review from cloud-fan

Assignees

No one assigned

Labels

SPARK CORE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Udbhav30 @dongjoon-hyun @SparkQA